fix: enable native tool calls for Requesty provider (ROO-235) #10211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Contributor
Review complete. No issues found. This PR properly fixes the Requesty provider tool selector issue by:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
dosubot
bot
added
size:M
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
- Add supportsNativeTools and defaultToolProtocol to Requesty model fetcher - Merge native tool defaults in RequestyHandler.getModel() for cached models - Apply same defaults merge in useSelectedModel for UI consistency - Also applied to Unbound provider for consistency The issue was that cached model data lacked the supportsNativeTools field, causing resolveToolProtocol() to return XML instead of native protocol.
- Add NATIVE_TOOL_DEFAULTS constant to @roo-code/types/tool.ts - Update RouterProvider.getModel() to merge defaults for all router providers (LiteLLM, Unbound) - Update RequestyHandler to use shared constant - Update useSelectedModel to use shared constant for requesty, unbound, litellm
daniel-lxs
force-pushed
the
dan/ROO-235-requesty-native-tools-fix
branch
from
194bdac to
660365e
Compare
cte
approved these changes
Dec 19, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Requesty provider missing tool selector issue (ROO-235).
Root Cause
supportsNativeToolsanddefaultToolProtocolin the model infoSolution
Backend Fix - Fetcher - Added
supportsNativeTools: trueanddefaultToolProtocol: "native"to the Requesty model fetcher so new fetches include these fieldsBackend Fix - Provider - In
RequestyHandler.getModel(), merge native tool defaults before the cached model info so that cached models without these fields get the defaults appliedFrontend Fix - In
useSelectedModel.ts, applied the same pattern aslitellm: merge native tool defaults for UI display consistencyApplied the same fix to the
unboundprovider for consistencyChanges
src/api/providers/fetchers/requesty.ts- AddedsupportsNativeToolsanddefaultToolProtocolfieldssrc/api/providers/requesty.ts- Merged native tool defaults ingetModel()for cached modelswebview-ui/src/components/ui/hooks/useSelectedModel.ts- Merged native tool defaults for requesty and unbound providersTesting
Fixes ROO-235
Important
Fixes Requesty provider tool selector issue by ensuring native tool support is set and cached models are updated, with similar fixes for Unbound provider.
requesty.ts, addedsupportsNativeTools: trueanddefaultToolProtocol: "native"to model info.RequestyHandler.getModel(), mergedNATIVE_TOOL_DEFAULTSwith cached model info.router-provider.ts, applied the same merge for cached models.useSelectedModel.ts, mergedNATIVE_TOOL_DEFAULTSfor Requesty and Unbound providers.This description was created by
for 660365e. You can customize this summary. It will automatically update as commits are pushed.